Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Submit feedback
Contribute to GitLab
Sign in
Toggle navigation
J
jquery
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
夏彬
jquery
Commits
80ad14bd
Commit
80ad14bd
authored
Jun 07, 2011
by
Mike Sherov
Committed by
timmywil
Jun 07, 2011
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Add margin after checking width. Add tests. Fixes #9441. Fixes #9300.
parent
07420566
Changes
2
Show whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
70 additions
and
21 deletions
+70
-21
css.js
src/css.js
+46
-21
dimensions.js
test/unit/dimensions.js
+24
-0
No files found.
src/css.js
View file @
80ad14bd
...
@@ -168,12 +168,11 @@ jQuery.curCSS = jQuery.css;
...
@@ -168,12 +168,11 @@ jQuery.curCSS = jQuery.css;
jQuery
.
each
([
"height"
,
"width"
],
function
(
i
,
name
)
{
jQuery
.
each
([
"height"
,
"width"
],
function
(
i
,
name
)
{
jQuery
.
cssHooks
[
name
]
=
{
jQuery
.
cssHooks
[
name
]
=
{
get
:
function
(
elem
,
computed
,
extra
)
{
get
:
function
(
elem
,
computed
,
extra
)
{
var
val
;
var
val
,
fellback
=
false
;
if
(
computed
)
{
if
(
computed
)
{
if
(
elem
.
offsetWidth
!==
0
)
{
if
(
elem
.
offsetWidth
!==
0
)
{
val
=
getWH
(
elem
,
name
,
extra
);
val
=
getWH
(
elem
,
name
,
extra
);
}
else
{
}
else
{
jQuery
.
swap
(
elem
,
cssShow
,
function
()
{
jQuery
.
swap
(
elem
,
cssShow
,
function
()
{
val
=
getWH
(
elem
,
name
,
extra
);
val
=
getWH
(
elem
,
name
,
extra
);
...
@@ -188,20 +187,37 @@ jQuery.each(["height", "width"], function( i, name ) {
...
@@ -188,20 +187,37 @@ jQuery.each(["height", "width"], function( i, name ) {
}
}
if
(
val
!=
null
)
{
if
(
val
!=
null
)
{
// Should return "auto" instead of 0, use 0 for
fellback
=
true
;
// temporary backwards-compat
return
val
===
""
||
val
===
"auto"
?
"0px"
:
val
;
}
}
}
}
if
(
val
<
0
||
val
==
null
)
{
if
(
!
fellback
&&
(
val
<
0
||
val
==
null
)
)
{
val
=
elem
.
style
[
name
];
val
=
elem
.
style
[
name
];
fellback
=
true
;
}
// Should return "auto" instead of 0, use 0 for
// Should return "auto" instead of 0, use 0 for
// temporary backwards-compat
// temporary backwards-compat
return
val
===
""
||
val
===
"auto"
?
"0px"
:
val
;
if
(
fellback
&&
(
val
===
""
||
val
===
"auto"
)
)
{
val
=
"0px"
;
}
else
if
(
typeof
val
!==
"string"
)
{
val
+=
"px"
;
}
if
(
extra
)
{
val
=
parseFloat
(
val
)
||
0
;
if
(
fellback
)
{
val
+=
adjustWH
(
elem
,
name
,
"padding"
);
if
(
extra
!==
"padding"
)
{
val
+=
adjustWH
(
elem
,
name
,
"border"
,
"Width"
);
}
}
if
(
extra
===
"margin"
)
{
val
+=
adjustWH
(
elem
,
name
,
"margin"
);
}
}
}
return
typeof
val
===
"string"
?
val
:
val
+
"px"
;
return
val
;
}
}
},
},
...
@@ -331,24 +347,33 @@ if ( document.documentElement.currentStyle ) {
...
@@ -331,24 +347,33 @@ if ( document.documentElement.currentStyle ) {
curCSS
=
getComputedStyle
||
currentStyle
;
curCSS
=
getComputedStyle
||
currentStyle
;
function
getWH
(
elem
,
name
,
extra
)
{
function
getWH
(
elem
,
name
,
extra
)
{
var
which
=
name
===
"width"
?
cssWidth
:
cssHeight
,
var
val
=
name
===
"width"
?
elem
.
offsetWidth
:
elem
.
offsetHeight
;
val
=
name
===
"width"
?
elem
.
offsetWidth
:
elem
.
offsetHeight
;
if
(
extra
===
"border"
)
{
if
(
extra
===
"border"
)
{
return
val
;
return
val
;
}
}
jQuery
.
each
(
which
,
function
()
{
if
(
!
extra
)
{
if
(
!
extra
)
{
val
-=
parseFloat
(
jQuery
.
css
(
elem
,
"padding"
+
this
))
||
0
;
val
-=
adjustWH
(
elem
,
name
,
"padding"
)
;
}
}
if
(
extra
===
"margin"
)
{
if
(
extra
!==
"margin"
)
{
val
+=
parseFloat
(
jQuery
.
css
(
elem
,
"margin"
+
this
))
||
0
;
val
-=
adjustWH
(
elem
,
name
,
"border"
,
"Width"
);
}
}
else
{
return
val
;
val
-=
parseFloat
(
jQuery
.
css
(
elem
,
"border"
+
this
+
"Width"
))
||
0
;
}
function
adjustWH
(
elem
,
name
,
prepend
,
append
)
{
var
which
=
name
===
"width"
?
cssWidth
:
cssHeight
,
val
=
0
;
if
(
!
append
){
append
=
""
;
}
}
jQuery
.
each
(
which
,
function
()
{
val
+=
parseFloat
(
jQuery
.
css
(
elem
,
prepend
+
this
+
append
)
)
||
0
;
});
});
return
val
;
return
val
;
...
...
test/unit/dimensions.js
View file @
80ad14bd
...
@@ -211,6 +211,30 @@ test("outerWidth()", function() {
...
@@ -211,6 +211,30 @@ test("outerWidth()", function() {
jQuery
.
removeData
(
$div
[
0
],
"olddisplay"
,
true
);
jQuery
.
removeData
(
$div
[
0
],
"olddisplay"
,
true
);
});
});
test
(
"child of a hidden elem has accurate inner/outer/Width()/Height() see #9441 #9300"
,
function
()
{
expect
(
8
);
//setup html
var
$divNormal
=
jQuery
(
'<div>'
).
css
({
width
:
"100px"
,
border
:
"10px solid white"
,
padding
:
"2px"
,
margin
:
"3px"
});
var
$divChild
=
$divNormal
.
clone
();
var
$divHiddenParent
=
jQuery
(
'<div>'
).
css
(
"display"
,
"none"
).
append
(
$divChild
);
jQuery
(
'body'
).
append
(
$divHiddenParent
).
append
(
$divNormal
);
//tests that child div of a hidden div works the same as a normal div
equals
(
$divChild
.
width
(),
$divNormal
.
width
(),
"child of a hidden element width() is wrong see #9441"
);
equals
(
$divChild
.
innerWidth
(),
$divNormal
.
innerWidth
(),
"child of a hidden element innerWidth() is wrong see #9441"
);
equals
(
$divChild
.
outerWidth
(),
$divNormal
.
outerWidth
(),
"child of a hidden element outerWidth() is wrong see #9441"
);
equals
(
$divChild
.
outerWidth
(
true
),
$divNormal
.
outerWidth
(
true
),
"child of a hidden element outerWidth( true ) is wrong see #9300"
);
equals
(
$divChild
.
height
(),
$divNormal
.
height
(),
"child of a hidden element height() is wrong see #9441"
);
equals
(
$divChild
.
innerHeight
(),
$divNormal
.
innerHeight
(),
"child of a hidden element innerHeight() is wrong see #9441"
);
equals
(
$divChild
.
outerHeight
(),
$divNormal
.
outerHeight
(),
"child of a hidden element outerHeight() is wrong see #9441"
);
equals
(
$divChild
.
outerHeight
(
true
),
$divNormal
.
outerHeight
(
true
),
"child of a hidden element outerHeight( true ) is wrong see #9300"
);
//teardown html
$divHiddenParent
.
remove
();
$divNormal
.
remove
();
});
test
(
"outerHeight()"
,
function
()
{
test
(
"outerHeight()"
,
function
()
{
expect
(
11
);
expect
(
11
);
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment