Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Submit feedback
Contribute to GitLab
Sign in
Toggle navigation
J
jquery
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
夏彬
jquery
Commits
cf672a2e
Commit
cf672a2e
authored
Sep 28, 2010
by
John Resig
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Make sure that .offset() doesn't fail against disconnected DOM nodes. Fixes #4996.
parent
7be11207
Changes
2
Show whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
18 additions
and
3 deletions
+18
-3
offset.js
src/offset.js
+9
-3
offset.js
test/unit/offset.js
+9
-0
No files found.
src/offset.js
View file @
cf672a2e
...
@@ -5,7 +5,7 @@ var rtable = /^t(?:able|d|h)$/i,
...
@@ -5,7 +5,7 @@ var rtable = /^t(?:able|d|h)$/i,
if
(
"getBoundingClientRect"
in
document
.
documentElement
)
{
if
(
"getBoundingClientRect"
in
document
.
documentElement
)
{
jQuery
.
fn
.
offset
=
function
(
options
)
{
jQuery
.
fn
.
offset
=
function
(
options
)
{
var
elem
=
this
[
0
];
var
elem
=
this
[
0
]
,
box
;
if
(
options
)
{
if
(
options
)
{
return
this
.
each
(
function
(
i
)
{
return
this
.
each
(
function
(
i
)
{
...
@@ -21,8 +21,14 @@ if ( "getBoundingClientRect" in document.documentElement ) {
...
@@ -21,8 +21,14 @@ if ( "getBoundingClientRect" in document.documentElement ) {
return
jQuery
.
offset
.
bodyOffset
(
elem
);
return
jQuery
.
offset
.
bodyOffset
(
elem
);
}
}
var
box
=
elem
.
getBoundingClientRect
(),
try
{
doc
=
elem
.
ownerDocument
,
box
=
elem
.
getBoundingClientRect
();
}
catch
(
e
)
{
box
=
{
top
:
elem
.
offsetTop
,
left
:
elem
.
offsetLeft
};
}
var
doc
=
elem
.
ownerDocument
,
body
=
doc
.
body
,
body
=
doc
.
body
,
docElem
=
doc
.
documentElement
,
docElem
=
doc
.
documentElement
,
win
=
getWindow
(
doc
),
win
=
getWindow
(
doc
),
...
...
test/unit/offset.js
View file @
cf672a2e
module
(
"offset"
);
module
(
"offset"
);
test
(
"disconnected node"
,
function
()
{
expect
(
2
);
var
result
=
jQuery
(
document
.
createElement
(
"div"
)
).
offset
();
equals
(
result
.
top
,
0
,
"Check top"
);
equals
(
result
.
left
,
0
,
"Check left"
);
});
var
supportsScroll
=
false
;
var
supportsScroll
=
false
;
testoffset
(
"absolute"
/* in iframe */
,
function
(
$
,
iframe
)
{
testoffset
(
"absolute"
/* in iframe */
,
function
(
$
,
iframe
)
{
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment