Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Submit feedback
Contribute to GitLab
Sign in
Toggle navigation
J
jquery
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
夏彬
jquery
Commits
ea9ec952
Commit
ea9ec952
authored
Jun 16, 2012
by
Sindre Sorhus
Committed by
Dave Methvin
Jun 16, 2012
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Fix #11231, (append|prepend|before|after) w/ array of jQuery objects.
Closes gh-666, thanks to @rkatic!
parent
9c28a320
Changes
2
Show whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
29 additions
and
4 deletions
+29
-4
manipulation.js
src/manipulation.js
+4
-0
manipulation.js
test/unit/manipulation.js
+25
-4
No files found.
src/manipulation.js
View file @
ea9ec952
...
@@ -289,6 +289,10 @@ jQuery.fn.extend({
...
@@ -289,6 +289,10 @@ jQuery.fn.extend({
},
},
domManip
:
function
(
args
,
table
,
callback
)
{
domManip
:
function
(
args
,
table
,
callback
)
{
// Flatten any nested arrays
args
=
[].
concat
.
apply
(
[],
args
);
var
results
,
first
,
fragment
,
iNoClone
,
var
results
,
first
,
fragment
,
iNoClone
,
i
=
0
,
i
=
0
,
value
=
args
[
0
],
value
=
args
[
0
],
...
...
test/unit/manipulation.js
View file @
ea9ec952
...
@@ -324,6 +324,12 @@ var testAppendForObject = function(valueObj, isFragment) {
...
@@ -324,6 +324,12 @@ var testAppendForObject = function(valueObj, isFragment) {
obj
.
append
(
valueObj
(
5
));
obj
.
append
(
valueObj
(
5
));
ok
(
obj
.
text
().
match
(
/5$/
),
"Check for appending a number"
+
objType
);
ok
(
obj
.
text
().
match
(
/5$/
),
"Check for appending a number"
+
objType
);
QUnit
.
reset
();
expected
=
"This link has class=
\"
blog
\"
: Simon Willison's WeblogTry them out:GoogleYahoo"
;
obj
=
getObj
();
obj
.
append
(
valueObj
(
[
jQuery
(
"#first"
),
jQuery
(
"#yahoo, #google"
)
]
)
);
equal
(
obj
.
text
(),
expected
,
"Check for appending of array of jQuery objects"
);
QUnit
.
reset
();
QUnit
.
reset
();
obj
=
getObj
();
obj
=
getObj
();
obj
.
append
(
valueObj
(
" text with spaces "
));
obj
.
append
(
valueObj
(
" text with spaces "
));
...
@@ -355,7 +361,7 @@ var testAppendForObject = function(valueObj, isFragment) {
...
@@ -355,7 +361,7 @@ var testAppendForObject = function(valueObj, isFragment) {
}
}
var
testAppend
=
function
(
valueObj
)
{
var
testAppend
=
function
(
valueObj
)
{
expect
(
5
6
);
expect
(
5
8
);
testAppendForObject
(
valueObj
,
false
);
testAppendForObject
(
valueObj
,
false
);
testAppendForObject
(
valueObj
,
true
);
testAppendForObject
(
valueObj
,
true
);
...
@@ -743,7 +749,7 @@ test("appendTo(String|Element|Array<Element>|jQuery)", function() {
...
@@ -743,7 +749,7 @@ test("appendTo(String|Element|Array<Element>|jQuery)", function() {
});
});
var
testPrepend
=
function
(
val
)
{
var
testPrepend
=
function
(
val
)
{
expect
(
5
);
expect
(
6
);
var
defaultText
=
"Try them out:"
var
defaultText
=
"Try them out:"
var
result
=
jQuery
(
"#first"
).
prepend
(
val
(
"<b>buga</b>"
));
var
result
=
jQuery
(
"#first"
).
prepend
(
val
(
"<b>buga</b>"
));
equal
(
result
.
text
(),
"buga"
+
defaultText
,
"Check if text prepending works"
);
equal
(
result
.
text
(),
"buga"
+
defaultText
,
"Check if text prepending works"
);
...
@@ -763,6 +769,11 @@ var testPrepend = function(val) {
...
@@ -763,6 +769,11 @@ var testPrepend = function(val) {
expected
=
"YahooTry them out:This link has class=
\"
blog
\"
: Simon Willison's Weblog"
;
expected
=
"YahooTry them out:This link has class=
\"
blog
\"
: Simon Willison's Weblog"
;
jQuery
(
"#sap"
).
prepend
(
val
(
jQuery
(
"#yahoo, #first"
)
));
jQuery
(
"#sap"
).
prepend
(
val
(
jQuery
(
"#yahoo, #first"
)
));
equal
(
jQuery
(
"#sap"
).
text
(),
expected
,
"Check for prepending of jQuery object"
);
equal
(
jQuery
(
"#sap"
).
text
(),
expected
,
"Check for prepending of jQuery object"
);
QUnit
.
reset
();
expected
=
"Try them out:GoogleYahooThis link has class=
\"
blog
\"
: Simon Willison's Weblog"
;
jQuery
(
"#sap"
).
prepend
(
val
(
[
jQuery
(
"#first"
),
jQuery
(
"#yahoo, #google"
)
]
)
);
equal
(
jQuery
(
"#sap"
).
text
(),
expected
,
"Check for prepending of array of jQuery objects"
);
};
};
test
(
"prepend(String|Element|Array<Element>|jQuery)"
,
function
()
{
test
(
"prepend(String|Element|Array<Element>|jQuery)"
,
function
()
{
...
@@ -854,7 +865,7 @@ test("prependTo(String|Element|Array<Element>|jQuery)", function() {
...
@@ -854,7 +865,7 @@ test("prependTo(String|Element|Array<Element>|jQuery)", function() {
});
});
var
testBefore
=
function
(
val
)
{
var
testBefore
=
function
(
val
)
{
expect
(
6
);
expect
(
7
);
var
expected
=
"This is a normal link: bugaYahoo"
;
var
expected
=
"This is a normal link: bugaYahoo"
;
jQuery
(
"#yahoo"
).
before
(
val
(
"<b>buga</b>"
));
jQuery
(
"#yahoo"
).
before
(
val
(
"<b>buga</b>"
));
equal
(
jQuery
(
"#en"
).
text
(),
expected
,
"Insert String before"
);
equal
(
jQuery
(
"#en"
).
text
(),
expected
,
"Insert String before"
);
...
@@ -874,6 +885,11 @@ var testBefore = function(val) {
...
@@ -874,6 +885,11 @@ var testBefore = function(val) {
jQuery
(
"#yahoo"
).
before
(
val
(
jQuery
(
"#mark, #first"
)
));
jQuery
(
"#yahoo"
).
before
(
val
(
jQuery
(
"#mark, #first"
)
));
equal
(
jQuery
(
"#en"
).
text
(),
expected
,
"Insert jQuery before"
);
equal
(
jQuery
(
"#en"
).
text
(),
expected
,
"Insert jQuery before"
);
QUnit
.
reset
();
expected
=
"This is a normal link: Try them out:GooglediveintomarkYahoo"
;
jQuery
(
"#yahoo"
).
before
(
val
(
[
jQuery
(
"#first"
),
jQuery
(
"#mark, #google"
)
]
)
);
equal
(
jQuery
(
"#en"
).
text
(),
expected
,
"Insert array of jQuery objects before"
);
var
set
=
jQuery
(
"<div/>"
).
before
(
"<span>test</span>"
);
var
set
=
jQuery
(
"<div/>"
).
before
(
"<span>test</span>"
);
equal
(
set
[
0
].
nodeName
.
toLowerCase
(),
"span"
,
"Insert the element before the disconnected node."
);
equal
(
set
[
0
].
nodeName
.
toLowerCase
(),
"span"
,
"Insert the element before the disconnected node."
);
equal
(
set
.
length
,
2
,
"Insert the element before the disconnected node."
);
equal
(
set
.
length
,
2
,
"Insert the element before the disconnected node."
);
...
@@ -918,7 +934,7 @@ test("insertBefore(String|Element|Array<Element>|jQuery)", function() {
...
@@ -918,7 +934,7 @@ test("insertBefore(String|Element|Array<Element>|jQuery)", function() {
});
});
var
testAfter
=
function
(
val
)
{
var
testAfter
=
function
(
val
)
{
expect
(
6
);
expect
(
7
);
var
expected
=
"This is a normal link: Yahoobuga"
;
var
expected
=
"This is a normal link: Yahoobuga"
;
jQuery
(
"#yahoo"
).
after
(
val
(
"<b>buga</b>"
));
jQuery
(
"#yahoo"
).
after
(
val
(
"<b>buga</b>"
));
equal
(
jQuery
(
"#en"
).
text
(),
expected
,
"Insert String after"
);
equal
(
jQuery
(
"#en"
).
text
(),
expected
,
"Insert String after"
);
...
@@ -938,6 +954,11 @@ var testAfter = function(val) {
...
@@ -938,6 +954,11 @@ var testAfter = function(val) {
jQuery
(
"#yahoo"
).
after
(
val
(
jQuery
(
"#mark, #first"
)
));
jQuery
(
"#yahoo"
).
after
(
val
(
jQuery
(
"#mark, #first"
)
));
equal
(
jQuery
(
"#en"
).
text
(),
expected
,
"Insert jQuery after"
);
equal
(
jQuery
(
"#en"
).
text
(),
expected
,
"Insert jQuery after"
);
QUnit
.
reset
();
expected
=
"This is a normal link: YahooTry them out:Googlediveintomark"
;
jQuery
(
"#yahoo"
).
after
(
val
(
[
jQuery
(
"#first"
),
jQuery
(
"#mark, #google"
)
]
)
);
equal
(
jQuery
(
"#en"
).
text
(),
expected
,
"Insert array of jQuery objects after"
);
var
set
=
jQuery
(
"<div/>"
).
after
(
"<span>test</span>"
);
var
set
=
jQuery
(
"<div/>"
).
after
(
"<span>test</span>"
);
equal
(
set
[
1
].
nodeName
.
toLowerCase
(),
"span"
,
"Insert the element after the disconnected node."
);
equal
(
set
[
1
].
nodeName
.
toLowerCase
(),
"span"
,
"Insert the element after the disconnected node."
);
equal
(
set
.
length
,
2
,
"Insert the element after the disconnected node."
);
equal
(
set
.
length
,
2
,
"Insert the element after the disconnected node."
);
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment