Commit 17bd6e9c authored by Timmy Willison's avatar Timmy Willison

Attributes: fix failing test for new return value

parent afca0318
...@@ -31,7 +31,7 @@ jQuery.extend({ ...@@ -31,7 +31,7 @@ jQuery.extend({
// don't get/set attributes on text, comment and attribute nodes // don't get/set attributes on text, comment and attribute nodes
if ( !elem || nType === 3 || nType === 8 || nType === 2 ) { if ( !elem || nType === 3 || nType === 8 || nType === 2 ) {
return; return null;
} }
// Fallback to prop when attributes are not supported // Fallback to prop when attributes are not supported
......
...@@ -377,8 +377,17 @@ test( "attr(String, Object)", function() { ...@@ -377,8 +377,17 @@ test( "attr(String, Object)", function() {
jQuery.each( [ window, document, obj, "#firstp" ], function( i, elem ) { jQuery.each( [ window, document, obj, "#firstp" ], function( i, elem ) {
var oldVal = elem.nonexisting, var oldVal = elem.nonexisting,
$elem = jQuery( elem ); $elem = jQuery( elem );
strictEqual( $elem.attr("nonexisting"), null, "attr works correctly for non existing attributes (bug #7500)." ); // Falls back to prop, which returns undefined
equal( $elem.attr( "nonexisting", "foo" ).attr("nonexisting"), "foo", "attr falls back to prop on unsupported arguments" ); strictEqual(
$elem.attr( "nonexisting" ),
typeof $elem[0].getAttribute === "undefined" ? undefined : null,
"attr works correctly for non existing attributes (bug #7500)."
);
equal(
$elem.attr( "nonexisting", "foo" ).attr( "nonexisting" ),
"foo",
"attr falls back to prop on unsupported arguments"
);
elem.nonexisting = oldVal; elem.nonexisting = oldVal;
}); });
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment