Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Submit feedback
Contribute to GitLab
Sign in
Toggle navigation
J
jquery
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
夏彬
jquery
Commits
17bd6e9c
Commit
17bd6e9c
authored
Mar 16, 2015
by
Timmy Willison
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Attributes: fix failing test for new return value
parent
afca0318
Changes
2
Show whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
12 additions
and
3 deletions
+12
-3
attr.js
src/attributes/attr.js
+1
-1
attributes.js
test/unit/attributes.js
+11
-2
No files found.
src/attributes/attr.js
View file @
17bd6e9c
...
@@ -31,7 +31,7 @@ jQuery.extend({
...
@@ -31,7 +31,7 @@ jQuery.extend({
// don't get/set attributes on text, comment and attribute nodes
// don't get/set attributes on text, comment and attribute nodes
if
(
!
elem
||
nType
===
3
||
nType
===
8
||
nType
===
2
)
{
if
(
!
elem
||
nType
===
3
||
nType
===
8
||
nType
===
2
)
{
return
;
return
null
;
}
}
// Fallback to prop when attributes are not supported
// Fallback to prop when attributes are not supported
...
...
test/unit/attributes.js
View file @
17bd6e9c
...
@@ -377,8 +377,17 @@ test( "attr(String, Object)", function() {
...
@@ -377,8 +377,17 @@ test( "attr(String, Object)", function() {
jQuery
.
each
(
[
window
,
document
,
obj
,
"#firstp"
],
function
(
i
,
elem
)
{
jQuery
.
each
(
[
window
,
document
,
obj
,
"#firstp"
],
function
(
i
,
elem
)
{
var
oldVal
=
elem
.
nonexisting
,
var
oldVal
=
elem
.
nonexisting
,
$elem
=
jQuery
(
elem
);
$elem
=
jQuery
(
elem
);
strictEqual
(
$elem
.
attr
(
"nonexisting"
),
null
,
"attr works correctly for non existing attributes (bug #7500)."
);
// Falls back to prop, which returns undefined
equal
(
$elem
.
attr
(
"nonexisting"
,
"foo"
).
attr
(
"nonexisting"
),
"foo"
,
"attr falls back to prop on unsupported arguments"
);
strictEqual
(
$elem
.
attr
(
"nonexisting"
),
typeof
$elem
[
0
].
getAttribute
===
"undefined"
?
undefined
:
null
,
"attr works correctly for non existing attributes (bug #7500)."
);
equal
(
$elem
.
attr
(
"nonexisting"
,
"foo"
).
attr
(
"nonexisting"
),
"foo"
,
"attr falls back to prop on unsupported arguments"
);
elem
.
nonexisting
=
oldVal
;
elem
.
nonexisting
=
oldVal
;
});
});
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment