Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Submit feedback
Contribute to GitLab
Sign in
Toggle navigation
J
jquery
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
夏彬
jquery
Commits
36a98b95
Commit
36a98b95
authored
Jan 11, 2010
by
jeresig
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Make sure we use detach instead of remove in replaceWith. Fixes #5785.
parent
366039a6
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
11 additions
and
2 deletions
+11
-2
manipulation.js
src/manipulation.js
+1
-1
manipulation.js
test/unit/manipulation.js
+10
-1
No files found.
src/manipulation.js
View file @
36a98b95
...
@@ -216,7 +216,7 @@ jQuery.fn.extend({
...
@@ -216,7 +216,7 @@ jQuery.fn.extend({
return
this
.
each
(
function
()
{
return
this
.
each
(
function
()
{
var
next
=
this
.
nextSibling
,
parent
=
this
.
parentNode
;
var
next
=
this
.
nextSibling
,
parent
=
this
.
parentNode
;
jQuery
(
this
).
remove
();
jQuery
(
this
).
detach
();
if
(
next
)
{
if
(
next
)
{
jQuery
(
next
).
before
(
value
);
jQuery
(
next
).
before
(
value
);
...
...
test/unit/manipulation.js
View file @
36a98b95
...
@@ -626,7 +626,7 @@ test("insertAfter(String|Element|Array<Element>|jQuery)", function() {
...
@@ -626,7 +626,7 @@ test("insertAfter(String|Element|Array<Element>|jQuery)", function() {
});
});
var
testReplaceWith
=
function
(
val
)
{
var
testReplaceWith
=
function
(
val
)
{
expect
(
1
4
);
expect
(
1
6
);
jQuery
(
'#yahoo'
).
replaceWith
(
val
(
'<b id="replace">buga</b>'
));
jQuery
(
'#yahoo'
).
replaceWith
(
val
(
'<b id="replace">buga</b>'
));
ok
(
jQuery
(
"#replace"
)[
0
],
'Replace element with string'
);
ok
(
jQuery
(
"#replace"
)[
0
],
'Replace element with string'
);
ok
(
!
jQuery
(
"#yahoo"
)[
0
],
'Verify that original element is gone, after string'
);
ok
(
!
jQuery
(
"#yahoo"
)[
0
],
'Verify that original element is gone, after string'
);
...
@@ -648,6 +648,15 @@ var testReplaceWith = function(val) {
...
@@ -648,6 +648,15 @@ var testReplaceWith = function(val) {
ok
(
jQuery
(
"#mark"
)[
0
],
'Replace element with set of elements'
);
ok
(
jQuery
(
"#mark"
)[
0
],
'Replace element with set of elements'
);
ok
(
!
jQuery
(
"#yahoo"
)[
0
],
'Verify that original element is gone, after set of elements'
);
ok
(
!
jQuery
(
"#yahoo"
)[
0
],
'Verify that original element is gone, after set of elements'
);
reset
();
var
tmp
=
jQuery
(
"<div/>"
).
appendTo
(
"body"
).
click
(
function
(){
ok
(
true
,
"Newly bound click run."
);
});
var
y
=
jQuery
(
'#yahoo'
).
click
(
function
(){
ok
(
true
,
"Previously bound click run."
);
});
y
.
replaceWith
(
tmp
);
tmp
.
click
();
y
.
click
();
reset
();
var
set
=
jQuery
(
"<div/>"
).
replaceWith
(
val
(
"<span>test</span>"
));
var
set
=
jQuery
(
"<div/>"
).
replaceWith
(
val
(
"<span>test</span>"
));
equals
(
set
[
0
].
nodeName
.
toLowerCase
(),
"span"
,
"Replace the disconnected node."
);
equals
(
set
[
0
].
nodeName
.
toLowerCase
(),
"span"
,
"Replace the disconnected node."
);
equals
(
set
.
length
,
1
,
"Replace the disconnected node."
);
equals
(
set
.
length
,
1
,
"Replace the disconnected node."
);
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment