Skip to content

J
jquery
Commit 453738ab authored by Michał Gołębiowski's avatar Michał Gołębiowski
Browse files
Options

Core: Change support.ownLast to support.ownFirst 

jQuery.support.ownLast was the only support test that was supposed
to be false when it succeeded. It was confusing.

Fixes gh-2406
Closes gh-2408
parent a0a5c0be
Hide whitespace changes
Inline Side-by-side
Showing with 14 additions and 14 deletions
src/core.js
View file @ 453738ab
...@@ -248,7 +248,7 @@ jQuery.extend({ ...@@ -248,7 +248,7 @@ jQuery.extend({
// Support: IE<9 // Support: IE<9
// Handle iteration over inherited properties before own properties. // Handle iteration over inherited properties before own properties.
if ( support.ownLast ) { if ( !support.ownFirst ) {
for ( key in obj ) { for ( key in obj ) {
return hasOwn.call( obj, key ); return hasOwn.call( obj, key );
} }
......
src/support.js
View file @ 453738ab
...@@ -12,7 +12,7 @@ var i; ...@@ -12,7 +12,7 @@ var i;
for ( i in jQuery( support ) ) { for ( i in jQuery( support ) ) {
break; break;
} }
support.ownLast = i !== "0"; support.ownFirst = i === "0";
// Note: most support tests are defined in their respective modules. // Note: most support tests are defined in their respective modules.
......
test/unit/support.js
View file @ 453738ab
...@@ -91,7 +91,7 @@ testIframeWithCallback( "Check CSP (https://developer.mozilla.org/en-US/docs/Sec ...@@ -91,7 +91,7 @@ testIframeWithCallback( "Check CSP (https://developer.mozilla.org/en-US/docs/Sec
"opacity": true, "opacity": true,
"optDisabled": true, "optDisabled": true,
"optSelected": true, "optSelected": true,
"ownLast": false, "ownFirst": true,
"pixelMarginRight": true, "pixelMarginRight": true,
"pixelPosition": true, "pixelPosition": true,
"radioValue": true, "radioValue": true,
...@@ -123,7 +123,7 @@ testIframeWithCallback( "Check CSP (https://developer.mozilla.org/en-US/docs/Sec ...@@ -123,7 +123,7 @@ testIframeWithCallback( "Check CSP (https://developer.mozilla.org/en-US/docs/Sec
"opacity": true, "opacity": true,
"optDisabled": true, "optDisabled": true,
"optSelected": false, "optSelected": false,
"ownLast": false, "ownFirst": true,
"pixelMarginRight": true, "pixelMarginRight": true,
"pixelPosition": true, "pixelPosition": true,
"radioValue": false, "radioValue": false,
...@@ -155,7 +155,7 @@ testIframeWithCallback( "Check CSP (https://developer.mozilla.org/en-US/docs/Sec ...@@ -155,7 +155,7 @@ testIframeWithCallback( "Check CSP (https://developer.mozilla.org/en-US/docs/Sec
"opacity": true, "opacity": true,
"optDisabled": true, "optDisabled": true,
"optSelected": false, "optSelected": false,
"ownLast": false, "ownFirst": true,
"pixelMarginRight": true, "pixelMarginRight": true,
"pixelPosition": true, "pixelPosition": true,
"radioValue": false, "radioValue": false,
...@@ -187,7 +187,7 @@ testIframeWithCallback( "Check CSP (https://developer.mozilla.org/en-US/docs/Sec ...@@ -187,7 +187,7 @@ testIframeWithCallback( "Check CSP (https://developer.mozilla.org/en-US/docs/Sec
"opacity": false, "opacity": false,
"optDisabled": true, "optDisabled": true,
"optSelected": false, "optSelected": false,
"ownLast": true, "ownFirst": false,
"pixelMarginRight": true, "pixelMarginRight": true,
"pixelPosition": false, "pixelPosition": false,
"radioValue": false, "radioValue": false,
...@@ -221,7 +221,7 @@ testIframeWithCallback( "Check CSP (https://developer.mozilla.org/en-US/docs/Sec ...@@ -221,7 +221,7 @@ testIframeWithCallback( "Check CSP (https://developer.mozilla.org/en-US/docs/Sec
"opacity": true, "opacity": true,
"optDisabled": true, "optDisabled": true,
"optSelected": true, "optSelected": true,
"ownLast": false, "ownFirst": true,
"pixelMarginRight": true, "pixelMarginRight": true,
"pixelPosition": true, "pixelPosition": true,
"radioValue": true, "radioValue": true,
...@@ -253,7 +253,7 @@ testIframeWithCallback( "Check CSP (https://developer.mozilla.org/en-US/docs/Sec ...@@ -253,7 +253,7 @@ testIframeWithCallback( "Check CSP (https://developer.mozilla.org/en-US/docs/Sec
"opacity": true, "opacity": true,
"optDisabled": true, "optDisabled": true,
"optSelected": true, "optSelected": true,
"ownLast": false, "ownFirst": true,
"pixelMarginRight": true, "pixelMarginRight": true,
"pixelPosition": false, "pixelPosition": false,
"radioValue": true, "radioValue": true,
...@@ -285,7 +285,7 @@ testIframeWithCallback( "Check CSP (https://developer.mozilla.org/en-US/docs/Sec ...@@ -285,7 +285,7 @@ testIframeWithCallback( "Check CSP (https://developer.mozilla.org/en-US/docs/Sec
"opacity": true, "opacity": true,
"optDisabled": true, "optDisabled": true,
"optSelected": true, "optSelected": true,
"ownLast": false, "ownFirst": true,
"pixelMarginRight": true, "pixelMarginRight": true,
"pixelPosition": false, "pixelPosition": false,
"radioValue": true, "radioValue": true,
...@@ -317,7 +317,7 @@ testIframeWithCallback( "Check CSP (https://developer.mozilla.org/en-US/docs/Sec ...@@ -317,7 +317,7 @@ testIframeWithCallback( "Check CSP (https://developer.mozilla.org/en-US/docs/Sec
"opacity": true, "opacity": true,
"optDisabled": true, "optDisabled": true,
"optSelected": true, "optSelected": true,
"ownLast": false, "ownFirst": true,
"pixelMarginRight": true, "pixelMarginRight": true,
"pixelPosition": true, "pixelPosition": true,
"radioValue": true, "radioValue": true,
...@@ -349,7 +349,7 @@ testIframeWithCallback( "Check CSP (https://developer.mozilla.org/en-US/docs/Sec ...@@ -349,7 +349,7 @@ testIframeWithCallback( "Check CSP (https://developer.mozilla.org/en-US/docs/Sec
"opacity": true, "opacity": true,
"optDisabled": true, "optDisabled": true,
"optSelected": true, "optSelected": true,
"ownLast": false, "ownFirst": true,
"pixelMarginRight": true, "pixelMarginRight": true,
"pixelPosition": false, "pixelPosition": false,
"radioValue": true, "radioValue": true,
...@@ -381,7 +381,7 @@ testIframeWithCallback( "Check CSP (https://developer.mozilla.org/en-US/docs/Sec ...@@ -381,7 +381,7 @@ testIframeWithCallback( "Check CSP (https://developer.mozilla.org/en-US/docs/Sec
"opacity": true, "opacity": true,
"optDisabled": true, "optDisabled": true,
"optSelected": true, "optSelected": true,
"ownLast": false, "ownFirst": true,
"pixelMarginRight": true, "pixelMarginRight": true,
"pixelPosition": false, "pixelPosition": false,
"radioValue": true, "radioValue": true,
...@@ -413,7 +413,7 @@ testIframeWithCallback( "Check CSP (https://developer.mozilla.org/en-US/docs/Sec ...@@ -413,7 +413,7 @@ testIframeWithCallback( "Check CSP (https://developer.mozilla.org/en-US/docs/Sec
"opacity": true, "opacity": true,
"optDisabled": true, "optDisabled": true,
"optSelected": true, "optSelected": true,
"ownLast": false, "ownFirst": true,
"pixelMarginRight": false, "pixelMarginRight": false,
"pixelPosition": false, "pixelPosition": false,
"radioValue": true, "radioValue": true,
...@@ -445,7 +445,7 @@ testIframeWithCallback( "Check CSP (https://developer.mozilla.org/en-US/docs/Sec ...@@ -445,7 +445,7 @@ testIframeWithCallback( "Check CSP (https://developer.mozilla.org/en-US/docs/Sec
"opacity": true, "opacity": true,
"optDisabled": false, "optDisabled": false,
"optSelected": true, "optSelected": true,
"ownLast": false, "ownFirst": true,
"pixelMarginRight": true, "pixelMarginRight": true,
"pixelPosition": false, "pixelPosition": false,
"radioValue": true, "radioValue": true,
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment