Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Submit feedback
Contribute to GitLab
Sign in
Toggle navigation
J
jquery
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
夏彬
jquery
Commits
628e1564
Commit
628e1564
authored
Dec 06, 2009
by
Dave Methvin
Committed by
John Resig
Dec 06, 2009
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Fix for #4011, crash when two text nodes are appended in IE.
parent
3c89e38f
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
6 additions
and
3 deletions
+6
-3
manipulation.js
src/manipulation.js
+3
-2
manipulation.js
test/unit/manipulation.js
+3
-1
No files found.
src/manipulation.js
View file @
628e1564
...
@@ -388,7 +388,7 @@ jQuery.extend({
...
@@ -388,7 +388,7 @@ jQuery.extend({
context
=
context
.
ownerDocument
||
context
[
0
]
&&
context
[
0
].
ownerDocument
||
document
;
context
=
context
.
ownerDocument
||
context
[
0
]
&&
context
[
0
].
ownerDocument
||
document
;
}
}
var
ret
=
[]
,
div
=
context
.
createElement
(
"div"
)
;
var
ret
=
[];
jQuery
.
each
(
elems
,
function
(
i
,
elem
){
jQuery
.
each
(
elems
,
function
(
i
,
elem
){
if
(
typeof
elem
===
"number"
)
{
if
(
typeof
elem
===
"number"
)
{
...
@@ -408,7 +408,8 @@ jQuery.extend({
...
@@ -408,7 +408,8 @@ jQuery.extend({
// Trim whitespace, otherwise indexOf won't work as expected
// Trim whitespace, otherwise indexOf won't work as expected
var
tag
=
(
rtagName
.
exec
(
elem
)
||
[
""
,
""
])[
1
].
toLowerCase
(),
var
tag
=
(
rtagName
.
exec
(
elem
)
||
[
""
,
""
])[
1
].
toLowerCase
(),
wrap
=
wrapMap
[
tag
]
||
wrapMap
.
_default
,
wrap
=
wrapMap
[
tag
]
||
wrapMap
.
_default
,
depth
=
wrap
[
0
];
depth
=
wrap
[
0
],
div
=
context
.
createElement
(
"div"
);
// Go to html and back, then peel off extra wrappers
// Go to html and back, then peel off extra wrappers
div
.
innerHTML
=
wrap
[
1
]
+
elem
+
wrap
[
2
];
div
.
innerHTML
=
wrap
[
1
]
+
elem
+
wrap
[
2
];
...
...
test/unit/manipulation.js
View file @
628e1564
...
@@ -151,7 +151,7 @@ test("unwrap()", function() {
...
@@ -151,7 +151,7 @@ test("unwrap()", function() {
});
});
var
testAppend
=
function
(
valueObj
)
{
var
testAppend
=
function
(
valueObj
)
{
expect
(
2
1
);
expect
(
2
2
);
var
defaultText
=
'Try them out:'
var
defaultText
=
'Try them out:'
var
result
=
jQuery
(
'#first'
).
append
(
valueObj
(
'<b>buga</b>'
));
var
result
=
jQuery
(
'#first'
).
append
(
valueObj
(
'<b>buga</b>'
));
equals
(
result
.
text
(),
defaultText
+
'buga'
,
'Check if text appending works'
);
equals
(
result
.
text
(),
defaultText
+
'buga'
,
'Check if text appending works'
);
...
@@ -224,6 +224,8 @@ var testAppend = function(valueObj) {
...
@@ -224,6 +224,8 @@ var testAppend = function(valueObj) {
t
(
"Append Select"
,
"#appendSelect1, #appendSelect2"
,
[
"appendSelect1"
,
"appendSelect2"
]
);
t
(
"Append Select"
,
"#appendSelect1, #appendSelect2"
,
[
"appendSelect1"
,
"appendSelect2"
]
);
equals
(
"Two nodes"
,
jQuery
(
'<div />'
).
append
(
"Two"
,
" nodes"
).
text
(),
"Appending two text nodes (#4011)"
);
// using contents will get comments regular, text, and comment nodes
// using contents will get comments regular, text, and comment nodes
var
j
=
jQuery
(
"#nonnodes"
).
contents
();
var
j
=
jQuery
(
"#nonnodes"
).
contents
();
var
d
=
jQuery
(
"<div/>"
).
appendTo
(
"#nonnodes"
).
append
(
j
);
var
d
=
jQuery
(
"<div/>"
).
appendTo
(
"#nonnodes"
).
append
(
j
);
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment