Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Submit feedback
Contribute to GitLab
Sign in
Toggle navigation
J
jquery
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
夏彬
jquery
Commits
63f19a95
Commit
63f19a95
authored
Jun 15, 2015
by
Timmy Willison
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Offset: return zeros for disconnected/hidden elements
Fixes gh-2310 Close gh-2396
parent
ee69e9c8
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
12 additions
and
15 deletions
+12
-15
offset.js
src/offset.js
+4
-1
offset.js
test/unit/offset.js
+8
-14
No files found.
src/offset.js
View file @
63f19a95
...
@@ -39,7 +39,7 @@ jQuery.offset = {
...
@@ -39,7 +39,7 @@ jQuery.offset = {
elem
.
style
.
position
=
"relative"
;
elem
.
style
.
position
=
"relative"
;
}
}
curOffset
=
curElem
.
offset
()
||
{
top
:
0
,
left
:
0
}
;
curOffset
=
curElem
.
offset
();
curCSSTop
=
jQuery
.
css
(
elem
,
"top"
);
curCSSTop
=
jQuery
.
css
(
elem
,
"top"
);
curCSSLeft
=
jQuery
.
css
(
elem
,
"left"
);
curCSSLeft
=
jQuery
.
css
(
elem
,
"left"
);
calculatePosition
=
(
position
===
"absolute"
||
position
===
"fixed"
)
&&
calculatePosition
=
(
position
===
"absolute"
||
position
===
"fixed"
)
&&
...
@@ -110,6 +110,9 @@ jQuery.fn.extend({
...
@@ -110,6 +110,9 @@ jQuery.fn.extend({
(
docElem
.
clientLeft
||
0
)
(
docElem
.
clientLeft
||
0
)
};
};
}
}
// Return zeros for disconnected and hidden elements (gh-2310)
return
rect
;
},
},
position
:
function
()
{
position
:
function
()
{
...
...
test/unit/offset.js
View file @
63f19a95
...
@@ -49,30 +49,24 @@ test("empty set", function() {
...
@@ -49,30 +49,24 @@ test("empty set", function() {
});
});
test
(
"disconnected element"
,
function
()
{
test
(
"disconnected element"
,
function
()
{
expect
(
1
);
expect
(
2
);
var
result
;
try
{
var
result
=
jQuery
(
document
.
createElement
(
"div"
)
).
offset
();
result
=
jQuery
(
document
.
createElement
(
"div"
)
).
offset
();
}
catch
(
e
)
{}
ok
(
!
result
,
"no position for disconnected element"
);
equal
(
result
.
top
,
0
,
"Retrieving offset on disconnected elements returns zeros (gh-2310)"
);
equal
(
result
.
left
,
0
,
"Retrieving offset on disconnected elements returns zeros (gh-2310)"
);
});
});
test
(
"hidden (display: none) element"
,
function
()
{
test
(
"hidden (display: none) element"
,
function
()
{
expect
(
1
);
expect
(
2
);
var
result
,
node
=
jQuery
(
"<div style='display: none' />"
).
appendTo
(
"#qunit-fixture"
);
try
{
var
node
=
jQuery
(
"<div style='display: none' />"
).
appendTo
(
"#qunit-fixture"
),
result
=
node
.
offset
();
result
=
node
.
offset
();
}
catch
(
e
)
{}
node
.
remove
();
node
.
remove
();
ok
(
!
result
,
"no position for hidden (display: none) element"
);
equal
(
result
.
top
,
0
,
"Retrieving offset on hidden elements returns zeros (gh-2310)"
);
equal
(
result
.
left
,
0
,
"Retrieving offset on hidden elements returns zeros (gh-2310)"
);
});
});
testIframe
(
"offset/absolute"
,
"absolute"
,
function
(
$
,
iframe
)
{
testIframe
(
"offset/absolute"
,
"absolute"
,
function
(
$
,
iframe
)
{
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment