Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Submit feedback
Contribute to GitLab
Sign in
Toggle navigation
J
jquery
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
夏彬
jquery
Commits
6736dd71
Commit
6736dd71
authored
Nov 15, 2011
by
Dave Methvin
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Fix #10794. .triggerHandler() should not .preventDefault().
This also provides a resolution for #10699.
parent
20cbf1b1
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
10 additions
and
12 deletions
+10
-12
event.js
src/event.js
+2
-11
event.js
test/unit/event.js
+8
-1
No files found.
src/event.js
View file @
6736dd71
...
...
@@ -281,11 +281,6 @@ jQuery.event = {
event
.
namespace_re
=
event
.
namespace
?
new
RegExp
(
"(^|
\\
.)"
+
namespaces
.
join
(
"
\\
.(?:.*
\\
.)?"
)
+
"(
\\
.|$)"
)
:
null
;
ontype
=
type
.
indexOf
(
":"
)
<
0
?
"on"
+
type
:
""
;
// triggerHandler() and global events don't bubble or run the default action
if
(
onlyHandlers
||
!
elem
)
{
event
.
preventDefault
();
}
// Handle a global trigger
if
(
!
elem
)
{
...
...
@@ -335,7 +330,7 @@ jQuery.event = {
}
// Fire handlers on the event path
for
(
i
=
0
;
i
<
eventPath
.
length
;
i
++
)
{
for
(
i
=
0
;
i
<
eventPath
.
length
&&
!
event
.
isPropagationStopped
()
;
i
++
)
{
cur
=
eventPath
[
i
][
0
];
event
.
type
=
eventPath
[
i
][
1
];
...
...
@@ -349,15 +344,11 @@ jQuery.event = {
if
(
handle
&&
jQuery
.
acceptData
(
cur
)
&&
handle
.
apply
(
cur
,
data
)
===
false
)
{
event
.
preventDefault
();
}
if
(
event
.
isPropagationStopped
()
)
{
break
;
}
}
event
.
type
=
type
;
// If nobody prevented the default action, do it now
if
(
!
event
.
isDefaultPrevented
()
)
{
if
(
!
onlyHandlers
&&
!
event
.
isDefaultPrevented
()
)
{
if
(
(
!
special
.
_default
||
special
.
_default
.
apply
(
elem
.
ownerDocument
,
data
)
===
false
)
&&
!
(
type
===
"click"
&&
jQuery
.
nodeName
(
elem
,
"a"
))
&&
jQuery
.
acceptData
(
elem
)
)
{
...
...
test/unit/event.js
View file @
6736dd71
...
...
@@ -1056,7 +1056,7 @@ test("trigger(type, [data], [fn])", function() {
});
test
(
"trigger(eventObject, [data], [fn])"
,
function
()
{
expect
(
2
5
);
expect
(
2
8
);
var
$parent
=
jQuery
(
"<div id='par' />"
).
hide
().
appendTo
(
"body"
),
$child
=
jQuery
(
"<p id='child'>foo</p>"
).
appendTo
(
$parent
);
...
...
@@ -1132,6 +1132,13 @@ test("trigger(eventObject, [data], [fn])", function() {
$child
.
unbind
();
$parent
.
unbind
().
remove
();
// Ensure triggerHandler doesn't molest its event object (#xxx)
var
event
=
jQuery
.
Event
(
"zowie"
);
jQuery
(
document
).
triggerHandler
(
event
);
equal
(
event
.
type
,
"zowie"
,
"Verify its type"
);
equal
(
event
.
isPropagationStopped
(),
false
,
"propagation not stopped"
);
equal
(
event
.
isDefaultPrevented
(),
false
,
"default not prevented"
);
});
test
(
".trigger() bubbling on disconnected elements (#10489)"
,
function
()
{
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment