Commit 77d7f264 authored by Rick Waldron's avatar Rick Waldron

Fixes #13779. Remove nodes in document order (uses for loop matching empty()).

parent db0326b1
...@@ -75,9 +75,10 @@ jQuery.fn.extend({ ...@@ -75,9 +75,10 @@ jQuery.fn.extend({
remove: function( selector, keepData ) { remove: function( selector, keepData ) {
var elem, var elem,
elems = selector ? jQuery.filter( selector, this ) : this, elems = selector ? jQuery.filter( selector, this ) : this,
i = elems.length; i = 0,
l = elems.length;
while ( i-- ) { for ( ; i < l; i++ ) {
elem = elems[ i ]; elem = elems[ i ];
if ( !keepData && elem.nodeType === 1 ) { if ( !keepData && elem.nodeType === 1 ) {
......
...@@ -1572,6 +1572,30 @@ test( "remove() event cleaning ", 1, function() { ...@@ -1572,6 +1572,30 @@ test( "remove() event cleaning ", 1, function() {
cleanUp.remove(); cleanUp.remove();
}); });
test( "remove() in document order #13779", 1, function() {
var last,
cleanData = jQuery.cleanData;
jQuery.cleanData = function( nodes ) {
last = nodes[0].textContent;
cleanData.call( this, nodes );
};
jQuery("#qunit-fixture").append(
jQuery.parseHTML(
"<div class='removal-fixture'>1</div>" +
"<div class='removal-fixture'>2</div>" +
"<div class='removal-fixture'>3</div>"
)
);
jQuery(".removal-fixture").remove();
equal( last, 3, "The removal fixtures were removed in document order" );
jQuery.cleanData = cleanData;
});
test( "detach()", 11, function() { test( "detach()", 11, function() {
testRemove("detach"); testRemove("detach");
}); });
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment