Core: Do not run window.onready when ready

Fixes #14802 (cherry picked from commit 2df1aad6)

Core: Do not run window.onready when ready
Fixes #14802 (cherry picked from commit 2df1aad6)
80e3dfa6 · Dave Methvin · 4adc5b22 · 80e3dfa6 · 80e3dfa6 · 80e3dfa6
Commit 80e3dfa6 authored Mar 04, 2014 by Dave Methvin
Hide whitespace changes
Inline Side-by-side

Showing with 34 additions and 2 deletions

ready.js src/core/ready.js +3 -2

onready.html test/data/core/onready.html +24 -0

core.js test/unit/core.js +7 -0

No files found.
--- a/src/core/ready.js
+++ b/src/core/ready.js
@@ -56,8 +56,9 @@ jQuery.extend({
 		readyList.resolveWith( document, [ jQuery ] );
 		// Trigger any bound ready events
-		if ( jQuery.fn.trigger ) {
+		if ( jQuery.fn.triggerHandler ) {
-			jQuery( document ).trigger("ready").off("ready");
+			jQuery( document ).triggerHandler( "ready" );
+			jQuery( document ).off( "ready" );
 		}
 	}
 });

--- a/test/data/core/onready.html
+++ b/test/data/core/onready.html
+<!doctype html>
+<html>
+<head>
+	<meta http-equiv="Content-type" content="text/html; charset=utf-8"/>
+	<title>alias-masked DOM properties (#14074)</title>
+	<script>
+		var error = false;
+		window.onready = function() { error = "Called window.onready"; };
+	</script>
+	<script src="../../jquery.js"></script>
+</head>
+<body>
+	<form>
+		<input type="text" id="nodeName"/>
+	</form>
+	<script>
+		jQuery(function() {
+			setTimeout( function() {
+				window.parent.iframeCallback( error );
+			});
+		});
+	</script>
+</body>
+</html>
\ No newline at end of file
--- a/test/unit/core.js
+++ b/test/unit/core.js
@@ -1492,3 +1492,10 @@ testIframeWithCallback( "Tolerating alias-masked DOM properties (#14074)", "core
 			deepEqual( errors, [], "jQuery loaded" );
 	}
 );
+testIframeWithCallback( "Don't call window.onready (#14802)", "core/onready.html",
+	function( error ) {
+			expect( 1 );
+			equal( error, false, "no call to user-defined onready" );
+	}
+);