Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Submit feedback
Contribute to GitLab
Sign in
Toggle navigation
J
jquery
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
夏彬
jquery
Commits
96152559
Commit
96152559
authored
Jan 19, 2009
by
John Resig
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Landing a fix for non-link anchor tabIndex (from scott.gonzalez). Fixes ticket #3916.
parent
d6e54142
Changes
3
Hide whitespace changes
Inline
Side-by-side
Showing
3 changed files
with
22 additions
and
18 deletions
+22
-18
core.js
src/core.js
+4
-2
index.html
test/index.html
+4
-1
core.js
test/unit/core.js
+14
-15
No files found.
src/core.js
View file @
96152559
...
@@ -986,9 +986,11 @@ jQuery.extend({
...
@@ -986,9 +986,11 @@ jQuery.extend({
var
attributeNode
=
elem
.
getAttributeNode
(
"tabIndex"
);
var
attributeNode
=
elem
.
getAttributeNode
(
"tabIndex"
);
return
attributeNode
&&
attributeNode
.
specified
return
attributeNode
&&
attributeNode
.
specified
?
attributeNode
.
value
?
attributeNode
.
value
:
elem
.
nodeName
.
match
(
/
^
(
a|area|button|input|object|select|textarea
)
$
/i
)
:
elem
.
nodeName
.
match
(
/
(
button|input|object|select|textarea
)
/i
)
?
0
?
0
:
undefined
;
:
elem
.
nodeName
.
match
(
/^
(
a|area
)
$/i
)
&&
elem
.
href
?
0
:
undefined
;
}
}
return
elem
[
name
];
return
elem
[
name
];
...
...
test/index.html
View file @
96152559
...
@@ -198,7 +198,7 @@ Z</textarea>
...
@@ -198,7 +198,7 @@ Z</textarea>
</div>
</div>
<div
id=
"tabindex-tests"
>
<div
id=
"tabindex-tests"
>
<ol
id=
"listWithTabIndex"
tabindex=
"
0
"
>
<ol
id=
"listWithTabIndex"
tabindex=
"
5
"
>
<li
id=
"foodWithNegativeTabIndex"
tabindex=
"-1"
>
Rice
</li>
<li
id=
"foodWithNegativeTabIndex"
tabindex=
"-1"
>
Rice
</li>
<li
id=
"foodNoTabIndex"
>
Beans
</li>
<li
id=
"foodNoTabIndex"
>
Beans
</li>
<li>
Blinis
</li>
<li>
Blinis
</li>
...
@@ -209,6 +209,9 @@ Z</textarea>
...
@@ -209,6 +209,9 @@ Z</textarea>
<span>
...
</span><a
href=
"#"
id=
"linkWithNoTabIndex"
>
Eat lots of food
</a><span>
...
</span>
|
<span>
...
</span><a
href=
"#"
id=
"linkWithNoTabIndex"
>
Eat lots of food
</a><span>
...
</span>
|
<span>
...
</span><a
href=
"#"
id=
"linkWithTabIndex"
tabindex=
"2"
>
Eat a little food
</a><span>
...
</span>
|
<span>
...
</span><a
href=
"#"
id=
"linkWithTabIndex"
tabindex=
"2"
>
Eat a little food
</a><span>
...
</span>
|
<span>
...
</span><a
href=
"#"
id=
"linkWithNegativeTabIndex"
tabindex=
"-1"
>
Eat no food
</a><span>
...
</span>
<span>
...
</span><a
href=
"#"
id=
"linkWithNegativeTabIndex"
tabindex=
"-1"
>
Eat no food
</a><span>
...
</span>
<span>
...
</span><a
id=
"linkWithNoHrefWithNoTabIndex"
>
Eat a burger
</a><span>
...
</span>
<span>
...
</span><a
id=
"linkWithNoHrefWithTabIndex"
tabindex=
"1"
>
Eat some funyuns
</a><span>
...
</span>
<span>
...
</span><a
id=
"linkWithNoHrefWithNegativeTabIndex"
tabindex=
"-1"
>
Eat some funyuns
</a><span>
...
</span>
</div>
</div>
</div>
</div>
</dl>
</dl>
...
...
test/unit/core.js
View file @
96152559
...
@@ -552,22 +552,21 @@ if ( !isLocal ) {
...
@@ -552,22 +552,21 @@ if ( !isLocal ) {
}
}
test
(
"attr('tabindex')"
,
function
()
{
test
(
"attr('tabindex')"
,
function
()
{
expect
(
5
);
expect
(
8
);
// tabindex 0
equals
(
jQuery
(
'#listWithTabIndex'
).
attr
(
'tabindex'
),
0
,
'tabindex of 0'
);
// positive tabindex
equals
(
jQuery
(
'#linkWithTabIndex'
).
attr
(
'tabindex'
),
2
,
'tabindex of 2'
);
// negative tabindex
equals
(
jQuery
(
'#linkWithNegativeTabIndex'
).
attr
(
'tabindex'
),
-
1
,
'negative tabindex'
);
// regular element without a tabindex
equals
(
jQuery
(
'#divWithNoTabIndex'
).
attr
(
'tabindex'
),
undefined
,
'no tabindex, not tabbable by default'
);
// link without a tabindex
// elements not natively tabbable
equals
(
jQuery
(
'#linkWithNoTabIndex'
).
attr
(
'tabindex'
),
0
,
'no tabindex, tabbable by default'
);
equals
(
jQuery
(
'#listWithTabIndex'
).
attr
(
'tabindex'
),
5
,
'not natively tabbable, with tabindex set to 0'
);
equals
(
jQuery
(
'#divWithNoTabIndex'
).
attr
(
'tabindex'
),
undefined
,
'not natively tabbable, no tabindex set'
);
// anchor with href
equals
(
jQuery
(
'#linkWithNoTabIndex'
).
attr
(
'tabindex'
),
0
,
'anchor with href, no tabindex set'
);
equals
(
jQuery
(
'#linkWithTabIndex'
).
attr
(
'tabindex'
),
2
,
'anchor with href, tabindex set to 2'
);
equals
(
jQuery
(
'#linkWithNegativeTabIndex'
).
attr
(
'tabindex'
),
-
1
,
'anchor with href, tabindex set to -1'
);
// anchor without href
equals
(
jQuery
(
'#linkWithNoHrefWithNoTabIndex'
).
attr
(
'tabindex'
),
undefined
,
'anchor without href, no tabindex set'
);
equals
(
jQuery
(
'#linkWithNoHrefWithTabIndex'
).
attr
(
'tabindex'
),
1
,
'anchor without href, tabindex set to 2'
);
equals
(
jQuery
(
'#linkWithNoHrefWithNegativeTabIndex'
).
attr
(
'tabindex'
),
-
1
,
'anchor without href, no tabindex set'
);
});
});
test
(
"attr('tabindex', value)"
,
function
()
{
test
(
"attr('tabindex', value)"
,
function
()
{
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment