Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Submit feedback
Contribute to GitLab
Sign in
Toggle navigation
J
jquery
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
夏彬
jquery
Commits
9e06903a
Commit
9e06903a
authored
Feb 26, 2010
by
jeresig
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Make sure that undefined is always returned for undefined data properties. Fixes #6166.
parent
7f5179b6
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
17 additions
and
7 deletions
+17
-7
data.js
src/data.js
+1
-1
data.js
test/unit/data.js
+16
-6
No files found.
src/data.js
View file @
9e06903a
...
@@ -25,7 +25,7 @@ jQuery.extend({
...
@@ -25,7 +25,7 @@ jQuery.extend({
var
id
=
elem
[
expando
],
cache
=
jQuery
.
cache
,
thisCache
;
var
id
=
elem
[
expando
],
cache
=
jQuery
.
cache
,
thisCache
;
if
(
!
id
&&
typeof
name
===
"string"
&&
data
===
undefined
)
{
if
(
!
id
&&
typeof
name
===
"string"
&&
data
===
undefined
)
{
return
null
;
return
;
}
}
// Compute a unique ID for the element
// Compute a unique ID for the element
...
...
test/unit/data.js
View file @
9e06903a
...
@@ -24,12 +24,15 @@ test("expando", function(){
...
@@ -24,12 +24,15 @@ test("expando", function(){
});
});
test
(
"jQuery.data"
,
function
()
{
test
(
"jQuery.data"
,
function
()
{
expect
(
8
);
expect
(
9
);
var
div
=
jQuery
(
"#foo"
)[
0
];
var
div
=
document
.
createElement
(
"div"
);
equals
(
jQuery
.
data
(
div
,
"test"
),
undefined
,
"Check for no data exists"
);
ok
(
jQuery
.
data
(
div
,
"test"
)
===
undefined
,
"Check for no data exists"
);
jQuery
.
data
(
div
,
"test"
,
"success"
);
jQuery
.
data
(
div
,
"test"
,
"success"
);
equals
(
jQuery
.
data
(
div
,
"test"
),
"success"
,
"Check for added data"
);
equals
(
jQuery
.
data
(
div
,
"test"
),
"success"
,
"Check for added data"
);
ok
(
jQuery
.
data
(
div
,
"notexist"
)
===
undefined
,
"Check for no data exists"
);
var
data
=
jQuery
.
data
(
div
);
var
data
=
jQuery
.
data
(
div
);
same
(
data
,
{
"test"
:
"success"
},
"Return complete data set"
);
same
(
data
,
{
"test"
:
"success"
},
"Return complete data set"
);
...
@@ -57,18 +60,25 @@ test(".data()", function() {
...
@@ -57,18 +60,25 @@ test(".data()", function() {
})
})
test
(
".data(String) and .data(String, Object)"
,
function
()
{
test
(
".data(String) and .data(String, Object)"
,
function
()
{
expect
(
22
);
expect
(
23
);
var
div
=
jQuery
(
"#foo"
);
var
div
=
jQuery
(
"<div/>"
);
equals
(
div
.
data
(
"test"
),
undefined
,
"Check for no data exists"
);
ok
(
div
.
data
(
"test"
)
===
undefined
,
"Check for no data exists"
);
div
.
data
(
"test"
,
"success"
);
div
.
data
(
"test"
,
"success"
);
equals
(
div
.
data
(
"test"
),
"success"
,
"Check for added data"
);
equals
(
div
.
data
(
"test"
),
"success"
,
"Check for added data"
);
div
.
data
(
"test"
,
"overwritten"
);
div
.
data
(
"test"
,
"overwritten"
);
equals
(
div
.
data
(
"test"
),
"overwritten"
,
"Check for overwritten data"
);
equals
(
div
.
data
(
"test"
),
"overwritten"
,
"Check for overwritten data"
);
div
.
data
(
"test"
,
undefined
);
div
.
data
(
"test"
,
undefined
);
equals
(
div
.
data
(
"test"
),
"overwritten"
,
"Check that data wasn't removed"
);
equals
(
div
.
data
(
"test"
),
"overwritten"
,
"Check that data wasn't removed"
);
div
.
data
(
"test"
,
null
);
div
.
data
(
"test"
,
null
);
ok
(
div
.
data
(
"test"
)
===
null
,
"Check for null data"
);
ok
(
div
.
data
(
"test"
)
===
null
,
"Check for null data"
);
ok
(
div
.
data
(
"notexist"
)
===
undefined
,
"Check for no data exists"
);
div
.
data
(
"test"
,
"overwritten"
);
div
.
data
(
"test"
,
"overwritten"
);
var
hits
=
{
test
:
0
},
gets
=
{
test
:
0
};
var
hits
=
{
test
:
0
},
gets
=
{
test
:
0
};
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment