Commit 9ec429cf authored by John Hoven's avatar John Hoven Committed by Dave Methvin

Attributes: Trim whitespace from option text when returned as a value

Fixes #14858
Ref #14686
Closes gh-1531
parent 5a1db91b
...@@ -210,4 +210,5 @@ S. Andrew Sheppard <andrew@wq.io> ...@@ -210,4 +210,5 @@ S. Andrew Sheppard <andrew@wq.io>
Roman Reiß <me@silverwind.io> Roman Reiß <me@silverwind.io>
Benjy Cui <benjytrys@gmail.com> Benjy Cui <benjytrys@gmail.com>
Rodrigo Rosenfeld Rosas <rr.rosas@gmail.com> Rodrigo Rosenfeld Rosas <rr.rosas@gmail.com>
John Hoven <hovenj@gmail.com>
...@@ -74,7 +74,9 @@ jQuery.extend({ ...@@ -74,7 +74,9 @@ jQuery.extend({
var val = jQuery.find.attr( elem, "value" ); var val = jQuery.find.attr( elem, "value" );
return val != null ? return val != null ?
val : val :
jQuery.text( elem ); // Support: IE10-11+
// option.text throws exceptions (#14686, #14858)
jQuery.trim( jQuery.text( elem ) );
} }
}, },
select: { select: {
......
...@@ -1462,3 +1462,16 @@ test( "should not throw at $(option).val() (#14686)", 1, function() { ...@@ -1462,3 +1462,16 @@ test( "should not throw at $(option).val() (#14686)", 1, function() {
ok( false ); ok( false );
} }
}); });
test( "Insignificant white space returned for $(option).val() (#14858)", function() {
expect ( 3 );
var val = jQuery( "<option></option>" ).val();
equal( val.length, 0, "Empty option should have no value" );
val = jQuery( "<option> </option>" ).val();
equal( val.length, 0, "insignificant white-space returned for value" );
val = jQuery( "<option> test </option>" ).val();
equal( val.length, 4, "insignificant white-space returned for value" );
});
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment