Commit b0a352bf authored by Dave Methvin's avatar Dave Methvin

Fix #12534. Don't die on browsers lacking getBoundingClientRect.

parent 74cdd784
...@@ -23,8 +23,8 @@ jQuery.fn.offset = function( options ) { ...@@ -23,8 +23,8 @@ jQuery.fn.offset = function( options ) {
docElem = doc.documentElement; docElem = doc.documentElement;
// Make sure we're not dealing with a disconnected DOM node // Make sure we have the API and we're it's not a disconnected DOM node
if ( !jQuery.contains( docElem, elem ) ) { if ( typeof elem.getBoundingClientRect === "undefined" || !jQuery.contains( docElem, elem ) ) {
return { top: 0, left: 0 }; return { top: 0, left: 0 };
} }
......
...@@ -15,6 +15,15 @@ test("empty set", function() { ...@@ -15,6 +15,15 @@ test("empty set", function() {
strictEqual( jQuery().position(), undefined, "position() returns undefined for empty set (#11962)" ); strictEqual( jQuery().position(), undefined, "position() returns undefined for empty set (#11962)" );
}); });
test("object without getBoundingClientRect", function() {
expect(2);
// Simulates a browser without gBCR on elements, we just want to return 0,0
var result = jQuery({ ownerDocument: document }).offset();
equal( result.top, 0, "Check top" );
equal( result.left, 0, "Check left" );
});
test("disconnected node", function() { test("disconnected node", function() {
expect(2); expect(2);
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment