Commit b5acda7a authored by Dave Methvin's avatar Dave Methvin

Followup to #12989 fix, improve unit test resiliency.

parent c2d6847d
...@@ -9,7 +9,7 @@ module( "ajax", { ...@@ -9,7 +9,7 @@ module( "ajax", {
}, },
teardown: function() { teardown: function() {
jQuery( document ).off( "ajaxStart ajaxStop ajaxSend ajaxComplete ajaxError ajaxSuccess" ); jQuery( document ).off( "ajaxStart ajaxStop ajaxSend ajaxComplete ajaxError ajaxSuccess" );
moduleTeardown(); moduleTeardown.apply( this, arguments );
} }
}); });
...@@ -19,16 +19,19 @@ module( "ajax", { ...@@ -19,16 +19,19 @@ module( "ajax", {
return; return;
} }
function addGlobalEvents() { function addGlobalEvents( expected ) {
jQuery( document ).on( "ajaxStart ajaxStop ajaxSend ajaxComplete ajaxError ajaxSuccess", function( e ) { return function() {
ok( true, e.type ); expected = expected || "";
}); jQuery( document ).on( "ajaxStart ajaxStop ajaxSend ajaxComplete ajaxError ajaxSuccess", function( e ) {
ok( expected.indexOf(e.type) !== -1, e.type );
});
};
} }
//----------- jQuery.ajax() //----------- jQuery.ajax()
ajaxTest( "jQuery.ajax() - success callbacks", 8, { ajaxTest( "jQuery.ajax() - success callbacks", 8, {
setup: addGlobalEvents, setup: addGlobalEvents("ajaxStart ajaxStop ajaxSend ajaxComplete ajaxSuccess"),
url: url("data/name.html"), url: url("data/name.html"),
beforeSend: function() { beforeSend: function() {
ok( true, "beforeSend" ); ok( true, "beforeSend" );
...@@ -42,7 +45,7 @@ module( "ajax", { ...@@ -42,7 +45,7 @@ module( "ajax", {
}); });
ajaxTest( "jQuery.ajax() - success callbacks - (url, options) syntax", 8, { ajaxTest( "jQuery.ajax() - success callbacks - (url, options) syntax", 8, {
setup: addGlobalEvents, setup: addGlobalEvents("ajaxStart ajaxStop ajaxSend ajaxComplete ajaxSuccess"),
create: function( options ) { create: function( options ) {
return jQuery.ajax( url("data/name.html"), options ); return jQuery.ajax( url("data/name.html"), options );
}, },
...@@ -58,7 +61,7 @@ module( "ajax", { ...@@ -58,7 +61,7 @@ module( "ajax", {
}); });
ajaxTest( "jQuery.ajax() - success callbacks (late binding)", 8, { ajaxTest( "jQuery.ajax() - success callbacks (late binding)", 8, {
setup: addGlobalEvents, setup: addGlobalEvents("ajaxStart ajaxStop ajaxSend ajaxComplete ajaxSuccess"),
url: url("data/name.html"), url: url("data/name.html"),
beforeSend: function() { beforeSend: function() {
ok( true, "beforeSend" ); ok( true, "beforeSend" );
...@@ -76,7 +79,7 @@ module( "ajax", { ...@@ -76,7 +79,7 @@ module( "ajax", {
}); });
ajaxTest( "jQuery.ajax() - success callbacks (oncomplete binding)", 8, { ajaxTest( "jQuery.ajax() - success callbacks (oncomplete binding)", 8, {
setup: addGlobalEvents, setup: addGlobalEvents("ajaxStart ajaxStop ajaxSend ajaxComplete ajaxSuccess"),
url: url("data/name.html"), url: url("data/name.html"),
beforeSend: function() { beforeSend: function() {
ok( true, "beforeSend" ); ok( true, "beforeSend" );
...@@ -94,7 +97,7 @@ module( "ajax", { ...@@ -94,7 +97,7 @@ module( "ajax", {
}); });
ajaxTest( "jQuery.ajax() - error callbacks", 8, { ajaxTest( "jQuery.ajax() - error callbacks", 8, {
setup: addGlobalEvents, setup: addGlobalEvents("ajaxStart ajaxStop ajaxSend ajaxComplete ajaxError"),
url: url("data/name.php?wait=5"), url: url("data/name.php?wait=5"),
beforeSend: function() { beforeSend: function() {
ok( true, "beforeSend" ); ok( true, "beforeSend" );
...@@ -334,7 +337,7 @@ module( "ajax", { ...@@ -334,7 +337,7 @@ module( "ajax", {
}); });
ajaxTest( "jQuery.ajax() - abort", 9, { ajaxTest( "jQuery.ajax() - abort", 9, {
setup: addGlobalEvents, setup: addGlobalEvents("ajaxStart ajaxStop ajaxSend ajaxError ajaxComplete"),
url: url("data/name.php?wait=5"), url: url("data/name.php?wait=5"),
beforeSend: function() { beforeSend: function() {
ok( true, "beforeSend" ); ok( true, "beforeSend" );
...@@ -439,21 +442,7 @@ module( "ajax", { ...@@ -439,21 +442,7 @@ module( "ajax", {
}); });
ajaxTest( "jQuery.ajax() - disabled globals", 3, { ajaxTest( "jQuery.ajax() - disabled globals", 3, {
setup: function() { setup: addGlobalEvents("ajaxStart ajaxStop ajaxSend ajaxComplete ajaxError ajaxSuccess"),
jQuery("#foo").ajaxStart(function() {
ok( false, "ajaxStart" );
}).ajaxStop(function() {
ok( false, "ajaxStop" );
}).ajaxSend(function() {
ok( false, "ajaxSend" );
}).ajaxComplete(function() {
ok( false, "ajaxComplete" );
}).ajaxError(function() {
ok( false, "ajaxError" );
}).ajaxSuccess(function() {
ok( false, "ajaxSuccess" );
});
},
global: false, global: false,
url: url("data/name.html"), url: url("data/name.html"),
beforeSend: function() { beforeSend: function() {
...@@ -1696,7 +1685,7 @@ module( "ajax", { ...@@ -1696,7 +1685,7 @@ module( "ajax", {
}); });
asyncTest( "jQuery.fn.load() - 404 error callbacks", 6, function() { asyncTest( "jQuery.fn.load() - 404 error callbacks", 6, function() {
addGlobalEvents(); addGlobalEvents("ajaxStart ajaxStop ajaxSend ajaxComplete ajaxError")();
jQuery( document ).ajaxStop( start ); jQuery( document ).ajaxStop( start );
jQuery("<div/>").load( "data/404.html", function() { jQuery("<div/>").load( "data/404.html", function() {
ok( true, "complete" ); ok( true, "complete" );
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment