Commit c0da49ff authored by Rick Waldron's avatar Rick Waldron Committed by Dave Methvin

Fix #11130: Don't neglect the data arg when event-map is passed.

parent d8289964
...@@ -867,9 +867,9 @@ jQuery.fn.extend({ ...@@ -867,9 +867,9 @@ jQuery.fn.extend({
// Types can be a map of types/handlers // Types can be a map of types/handlers
if ( typeof types === "object" ) { if ( typeof types === "object" ) {
// ( types-Object, selector, data ) // ( types-Object, selector, data )
if ( typeof selector !== "string" ) { if ( typeof selector !== "string" ) { // && selector != null
// ( types-Object, data ) // ( types-Object, data )
data = selector; data = data || selector;
selector = undefined; selector = undefined;
} }
for ( type in types ) { for ( type in types ) {
......
...@@ -1197,7 +1197,7 @@ test("Delegated events in SVG (#10791)", function() { ...@@ -1197,7 +1197,7 @@ test("Delegated events in SVG (#10791)", function() {
'<rect id="svg-by-id" x="10" y="20" width="100" height="60" r="10" rx="10" ry="10"></rect>'+ '<rect id="svg-by-id" x="10" y="20" width="100" height="60" r="10" rx="10" ry="10"></rect>'+
'</svg>' '</svg>'
).appendTo( "body" ); ).appendTo( "body" );
jQuery( "body" ) jQuery( "body" )
.on( "click", "#svg-by-id", function() { .on( "click", "#svg-by-id", function() {
ok( true, "delegated id selector" ); ok( true, "delegated id selector" );
...@@ -2601,7 +2601,7 @@ test("special bind/delegate name mapping", function() { ...@@ -2601,7 +2601,7 @@ test("special bind/delegate name mapping", function() {
// Ensure .one() events are removed after their maiden voyage // Ensure .one() events are removed after their maiden voyage
jQuery( '<p>Gut Feeling</p>' ) jQuery( '<p>Gut Feeling</p>' )
.one( "gutfeeling", jQuery.noop ) .one( "gutfeeling", jQuery.noop )
.trigger( "gutfeeling" ) // This one should .trigger( "gutfeeling" ) // This one should
.trigger( "gutfeeling" ) // This one should not .trigger( "gutfeeling" ) // This one should not
.remove(); .remove();
...@@ -2616,7 +2616,7 @@ test(".on and .off, selective mixed removal (#10705)", function() { ...@@ -2616,7 +2616,7 @@ test(".on and .off, selective mixed removal (#10705)", function() {
ok( true, "triggered " + e.type ); ok( true, "triggered " + e.type );
}; };
jQuery( '<p>Strange Pursuit</p>' ) jQuery( "<p>Strange Pursuit</p>" )
.on( "click", timingx ) .on( "click", timingx )
.on( "click.duty", timingx ) .on( "click.duty", timingx )
.on( "click.now", timingx ) .on( "click.now", timingx )
...@@ -2631,6 +2631,22 @@ test(".on and .off, selective mixed removal (#10705)", function() { ...@@ -2631,6 +2631,22 @@ test(".on and .off, selective mixed removal (#10705)", function() {
.trigger( "click" ); // 0 .trigger( "click" ); // 0
}); });
test(".on( event-map, null-selector, data ) #11130", function() {
expect( 1 );
var $p = jQuery("<p>Strange Pursuit</p>"),
data = "bar",
map = {
"foo": function( event ) {
equal( event.data, "bar", "event.data correctly relayed with null selector" );
$p.remove();
}
};
$p.on( map, null, data ).trigger("foo");
});
test("delegated events quickIs", function() { test("delegated events quickIs", function() {
expect(14); expect(14);
var markup = jQuery( var markup = jQuery(
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment