Commit c27d5ca6 authored by Dave Methvin's avatar Dave Methvin

By default, use document root rather than current selection's context when...

By default, use document root rather than current selection's context when add()ing elements. Fixes #7853.
parent 5fd21fc0
...@@ -134,7 +134,7 @@ jQuery.fn.extend({ ...@@ -134,7 +134,7 @@ jQuery.fn.extend({
add: function( selector, context ) { add: function( selector, context ) {
var set = typeof selector === "string" ? var set = typeof selector === "string" ?
jQuery( selector, context || this.context ) : jQuery( selector, context ) :
jQuery.makeArray( selector ), jQuery.makeArray( selector ),
all = jQuery.merge( this.get(), set ); all = jQuery.merge( this.get(), set );
......
...@@ -440,12 +440,13 @@ test("add(String|Element|Array|undefined)", function() { ...@@ -440,12 +440,13 @@ test("add(String|Element|Array|undefined)", function() {
test("add(String, Context)", function() { test("add(String, Context)", function() {
expect(6); expect(6);
equals( jQuery(document).add("#form").length, 2, "Make sure that using regular context document still works." ); equals( jQuery("#firstp").add("#ap").length, 2, "Add selector to selector" );
equals( jQuery(document.body).add("#form").length, 2, "Using a body context." ); equals( jQuery(document.getElementById("firstp")).add("#ap").length, 2, "Add gEBId to selector" );
equals( jQuery(document.body).add("#html").length, 1, "Using a body context." ); equals( jQuery(document.getElementById("firstp")).add(document.getElementById("ap")).length, 2, "Add gEBId to gEBId" );
equals( jQuery(document).add("#form", document).length, 2, "Use a passed in document context." ); var ctx = document.getElementById("firstp");
equals( jQuery(document).add("#form", document.body).length, 2, "Use a passed in body context." ); equals( jQuery("#firstp").add("#ap", ctx).length, 1, "Add selector to selector with context" );
equals( jQuery(document).add("#html", document.body).length, 1, "Use a passed in body context." ); equals( jQuery(document.getElementById("firstp")).add("#ap", ctx).length, 1, "Add gEBId to selector with context" );
equals( jQuery(document.getElementById("firstp")).add(document.getElementById("ap"), ctx).length, 2, "Add gEBId to gEBId with context" );
}); });
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment