Commit c72b0f32 authored by timmywil's avatar timmywil

Check empty string instead of specified as specified is inconsistent on the...

Check empty string instead of specified as specified is inconsistent on the name attribute. Fixes #9148.
parent f7f84500
...@@ -491,8 +491,8 @@ if ( !jQuery.support.getSetAttribute ) { ...@@ -491,8 +491,8 @@ if ( !jQuery.support.getSetAttribute ) {
return elem.getAttribute( name ); return elem.getAttribute( name );
} }
ret = elem.getAttributeNode( name ); ret = elem.getAttributeNode( name );
// Return undefined if not specified instead of empty string // Return undefined if nodeValue is empty string
return ret && ret.specified ? return ret && ret.nodeValue !== "" ?
ret.nodeValue : ret.nodeValue :
undefined; undefined;
}, },
......
...@@ -144,7 +144,7 @@ test("attr(Hash)", function() { ...@@ -144,7 +144,7 @@ test("attr(Hash)", function() {
}); });
test("attr(String, Object)", function() { test("attr(String, Object)", function() {
expect(57); expect(58);
var div = jQuery("div").attr("foo", "bar"), var div = jQuery("div").attr("foo", "bar"),
fail = false; fail = false;
...@@ -164,6 +164,8 @@ test("attr(String, Object)", function() { ...@@ -164,6 +164,8 @@ test("attr(String, Object)", function() {
equals( jQuery("#name").attr("name"), "something", "Set name attribute" ); equals( jQuery("#name").attr("name"), "something", "Set name attribute" );
jQuery("#name").attr("name", null); jQuery("#name").attr("name", null);
equals( jQuery("#name").attr("name"), undefined, "Remove name attribute" ); equals( jQuery("#name").attr("name"), undefined, "Remove name attribute" );
var $input = jQuery("<input>", { name: "something" });
equals( $input.attr("name"), "something", "Check element creation gets/sets the name attribute." );
jQuery("#check2").prop("checked", true).prop("checked", false).attr("checked", true); jQuery("#check2").prop("checked", true).prop("checked", false).attr("checked", true);
equals( document.getElementById("check2").checked, true, "Set checked attribute" ); equals( document.getElementById("check2").checked, true, "Set checked attribute" );
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment