Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Submit feedback
Contribute to GitLab
Sign in
Toggle navigation
J
jquery
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
夏彬
jquery
Commits
c9ef09c8
Commit
c9ef09c8
authored
Mar 05, 2011
by
Jordan Boesch
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
bug 6158; fixing replaceWith from throwing errors on non existant elements
parent
5c2d7097
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
8 additions
and
6 deletions
+8
-6
manipulation.js
src/manipulation.js
+3
-4
manipulation.js
test/unit/manipulation.js
+5
-2
No files found.
src/manipulation.js
View file @
c9ef09c8
...
...
@@ -261,10 +261,9 @@ jQuery.fn.extend({
}
});
}
else
{
if
(
!
this
.
length
)
{
return
this
;
}
return
this
.
pushStack
(
jQuery
(
jQuery
.
isFunction
(
value
)
?
value
()
:
value
),
"replaceWith"
,
value
);
return
(
this
.
length
)
?
this
.
pushStack
(
jQuery
(
jQuery
.
isFunction
(
value
)
?
value
()
:
value
),
"replaceWith"
,
value
)
:
this
;
}
},
...
...
test/unit/manipulation.js
View file @
c9ef09c8
...
...
@@ -739,7 +739,7 @@ test("insertAfter(String|Element|Array<Element>|jQuery)", function() {
});
var
testReplaceWith
=
function
(
val
)
{
expect
(
2
0
);
expect
(
2
1
);
jQuery
(
'#yahoo'
).
replaceWith
(
val
(
'<b id="replace">buga</b>'
));
ok
(
jQuery
(
"#replace"
)[
0
],
'Replace element with string'
);
ok
(
!
jQuery
(
"#yahoo"
)[
0
],
'Verify that original element is gone, after string'
);
...
...
@@ -799,6 +799,9 @@ var testReplaceWith = function(val) {
var
set
=
jQuery
(
"<div/>"
).
replaceWith
(
val
(
"<span>test</span>"
));
equals
(
set
[
0
].
nodeName
.
toLowerCase
(),
"span"
,
"Replace the disconnected node."
);
equals
(
set
.
length
,
1
,
"Replace the disconnected node."
);
var
non_existant
=
jQuery
(
'#does-not-exist'
).
replaceWith
(
val
(
"<b>should not throw an error</b>"
)
);
equals
(
non_existant
.
length
,
0
,
"Length of non existant element."
)
var
$div
=
jQuery
(
"<div class='replacewith'></div>"
).
appendTo
(
"body"
);
// TODO: Work on jQuery(...) inline script execution
...
...
@@ -827,7 +830,7 @@ test("replaceWith(String|Element|Array<Element>|jQuery)", function() {
test
(
"replaceWith(Function)"
,
function
()
{
testReplaceWith
(
functionReturningObj
);
expect
(
2
1
);
expect
(
2
2
);
var
y
=
jQuery
(
"#yahoo"
)[
0
];
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment