Commit dc49f62f authored by Timmy Willison's avatar Timmy Willison

Offset: allow offset setter to throw for disconnected elements

Fixes gh-2114
parent a2386a82
...@@ -39,7 +39,7 @@ jQuery.offset = { ...@@ -39,7 +39,7 @@ jQuery.offset = {
elem.style.position = "relative"; elem.style.position = "relative";
} }
curOffset = curElem.offset() || { top: 0, left: 0 }; curOffset = curElem.offset();
curCSSTop = jQuery.css( elem, "top" ); curCSSTop = jQuery.css( elem, "top" );
curCSSLeft = jQuery.css( elem, "left" ); curCSSLeft = jQuery.css( elem, "left" );
calculatePosition = ( position === "absolute" || position === "fixed" ) && calculatePosition = ( position === "absolute" || position === "fixed" ) &&
......
...@@ -36,10 +36,6 @@ test("jQuery()", function() { ...@@ -36,10 +36,6 @@ test("jQuery()", function() {
expected++; expected++;
attrObj["width"] = 10; attrObj["width"] = 10;
} }
if ( jQuery.fn.offset ) {
expected++;
attrObj["offset"] = { "top": 1, "left": 1 };
}
if ( jQuery.fn.css ) { if ( jQuery.fn.css ) {
expected += 2; expected += 2;
attrObj["css"] = { "paddingLeft": 1, "paddingRight": 1 }; attrObj["css"] = { "paddingLeft": 1, "paddingRight": 1 };
...@@ -105,16 +101,12 @@ test("jQuery()", function() { ...@@ -105,16 +101,12 @@ test("jQuery()", function() {
elem = jQuery("\n\n<em>world</em>")[0]; elem = jQuery("\n\n<em>world</em>")[0];
equal( elem.nodeName.toLowerCase(), "em", "leading newlines" ); equal( elem.nodeName.toLowerCase(), "em", "leading newlines" );
elem = jQuery("<div/>", attrObj ); elem = jQuery( "<div/>", attrObj );
if ( jQuery.fn.width ) { if ( jQuery.fn.width ) {
equal( elem[0].style.width, "10px", "jQuery() quick setter width"); equal( elem[0].style.width, "10px", "jQuery() quick setter width");
} }
if ( jQuery.fn.offset ) {
equal( elem[0].style.top, "1px", "jQuery() quick setter offset");
}
if ( jQuery.fn.css ) { if ( jQuery.fn.css ) {
equal( elem[0].style.paddingLeft, "1px", "jQuery quick setter css"); equal( elem[0].style.paddingLeft, "1px", "jQuery quick setter css");
equal( elem[0].style.paddingRight, "1px", "jQuery quick setter css"); equal( elem[0].style.paddingRight, "1px", "jQuery quick setter css");
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment