Commit f5163914 authored by Dave Methvin's avatar Dave Methvin

Fix #13471. $().on(".xyz"...) should avoid later crash.

If the event type is an empty string we end up hanging in .off() which makes for
mighty hard debugging. Instead treat it as a no-op. Docs seem clear this is not
allowed.
parent dabdea70
......@@ -67,6 +67,11 @@ jQuery.event = {
tmp = rtypenamespace.exec( types[t] ) || [];
type = origType = tmp[1];
namespaces = ( tmp[2] || "" ).split( "." ).sort();
// There *must* be a type, no attaching namespace-only handlers
if ( !type ) {
continue;
}
// If event changes its type, use the special event handlers for the changed type
special = jQuery.event.special[ type ] || {};
......
......@@ -555,6 +555,22 @@ test("bind(), multi-namespaced events", function() {
jQuery("#firstp").trigger("custom");
});
test("namespace-only event binding is a no-op", function(){
expect(2);
jQuery("#firstp")
.on( ".whoops", function() {
ok( false, "called a namespace-only event" );
})
.on( "whoops", function() {
ok( true, "called whoops" );
})
.trigger("whoops") // 1
.off(".whoops")
.trigger("whoops") // 2
.off("whoops");
});
test("bind(), with same function", function() {
expect(2);
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment