1. 02 Nov, 2012 1 commit
  2. 01 Nov, 2012 6 commits
  3. 31 Oct, 2012 1 commit
  4. 30 Oct, 2012 1 commit
  5. 29 Oct, 2012 3 commits
    • Oleg's avatar
    • Dave Methvin's avatar
      Update authors. · 5be4c10c
      Dave Methvin authored
      5be4c10c
    • Timo Tijhof's avatar
      Implement expectation test instead of using _removeData. Close gh-997. · 36c9ecb0
      Timo Tijhof authored
      * Removed inline usage of QUnit.reset() because it is messing with the
        expectation model as reset does .empty() which does a recursive cleanData
        on everything in #qunit-fixture, so any expectJqData above .reset() would
        fail negatively.
      
        Instead of calling reset inline, either updated the following assertions to
        take previous assertions' state into account, or broke the test() up into
        2 tests at the point where it would call QUnit.reset.
      
      * After introducing the new memory leak discovery a whole bunch of tests were
        failing as they didn't clean up everything. However I didn't (yet) add
        QUnit.expectJqData calls all over the place because in most if not all of
        these cases it is valid data storage. For example in test "data()", there
        will be an internal data key for "parsedAttrs". This particular test isn't
        intending to test for memory leaks, so therefor I made the new discovery
        system only push failures when the test contains at least 1 call to
        QUnit.expectJqData.
      
        When not, we'll assume that whatever data is being stored is acceptable
        because the relevant elements still exist in the DOM anyway (QUnit.reset
        will remove the elements and clean up the data automatically).
      
        I did add a "Always check jQuery.data" mode in the test suite that will
        trigger it everywhere. Maybe one day we'll include a call to everywhere,
        but for now I'm keeping the status quo: Only consider data left in storage
        to be a problem if the test says so ("opt-in").
      
      * Had to move #fx-tests inside the fixture because ".remove()" test would
        otherwise remove stuff permanently and cause random other tests to fail
        as "#hide div" would yield an empty collection.
        (Why wasn't this in the fixture in the first place?)
      
        As a result moving fx-tests into the fixture a whole bunch of tests failed
        that relied on arbitrary stuff about the document-wide or fixture-wide
        state (e.g. number of divs etc.). So I had to adjust various tests to
        limit their sample data to not be so variable and unlimited...
      
      * Moved out tests for expando cleanup into a separate test.
      
      * Fixed implied global variable 'pass' in effects.js that was causing
        "TypeError: boolean is not a function" in *UNRELATED* dimensions.js that
        uses a global variable "pass = function () {};" ...
      
      * Removed spurious calls to _removeData. The new test exposed various failures
        e.g. where div[0] isn't being assigned any data anyway.
        (queue.js and attributes.js toggleClass).
      
      * Removed spurious clean up at the bottom of test() functions that are
        already covered by the teardown (calling QUnit.reset or removeClass to
        supposedly undo any changes).
      
      * Documented the parentheses-less magic line in toggleClass. It appeared that
        it would always keep the current class name if there was any (since the
        assignment started with "this.className || ...".
      
        Adding parentheses + spacing is 8 bytes (though only 1 in gzip apparently).
        Only added the comment for now, though I prefer clarity with logical
        operators, I'd rather not face the yayMinPD[1] in this test-related commit.
      
      * Updated QUnit urlConfig to the new format (raw string is deprecated).
      
      * Clean up odd htmlentities in test titles, QUnit escapes this.
        (^\s+test\(.*)(&gt\;) → $1>
        (^\s+test\(.*)(&lt\;) → $1<
      
      [1] jQuery MinJsGz Release Police Department (do the same, download less)
      36c9ecb0
  6. 27 Oct, 2012 1 commit
  7. 26 Oct, 2012 1 commit
  8. 25 Oct, 2012 7 commits
  9. 24 Oct, 2012 3 commits
  10. 23 Oct, 2012 1 commit
  11. 22 Oct, 2012 4 commits
  12. 21 Oct, 2012 10 commits
  13. 20 Oct, 2012 1 commit