Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Submit feedback
Contribute to GitLab
Sign in
Toggle navigation
Y
yii2bootstrap
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
夏彬
yii2bootstrap
Commits
4133d6b2
Commit
4133d6b2
authored
Mar 03, 2016
by
artur
Committed by
Carsten Brandt
Mar 04, 2016
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Fix: get item container from config
- Add unit test for check rendering item container close #124
parent
ef941bc8
Changes
3
Hide whitespace changes
Inline
Side-by-side
Showing
3 changed files
with
23 additions
and
1 deletion
+23
-1
CHANGELOG.md
CHANGELOG.md
+1
-0
Tabs.php
Tabs.php
+2
-1
TabsTest.php
tests/TabsTest.php
+20
-0
No files found.
CHANGELOG.md
View file @
4133d6b2
...
@@ -7,6 +7,7 @@ Yii Framework 2 bootstrap extension Change Log
...
@@ -7,6 +7,7 @@ Yii Framework 2 bootstrap extension Change Log
-
Bug #68: Fixed
`yii\bootstrap\Nav`
handling empty items (freezy-sk)
-
Bug #68: Fixed
`yii\bootstrap\Nav`
handling empty items (freezy-sk)
-
Bug #81: Fixed
`yii\bootstrap\ActiveField::radioList()`
and
`yii\bootstrap\ActiveField::checkboxList()`
ignore
`itemOptions`
(mikehaertl)
-
Bug #81: Fixed
`yii\bootstrap\ActiveField::radioList()`
and
`yii\bootstrap\ActiveField::checkboxList()`
ignore
`itemOptions`
(mikehaertl)
-
Bug #98: Fixed
`yii\bootstrap\ButtonDropdown`
setting
`href`
attribute for non
`a`
tags (13nightevil)
-
Bug #98: Fixed
`yii\bootstrap\ButtonDropdown`
setting
`href`
attribute for non
`a`
tags (13nightevil)
-
Bug #124: Fixed
`yii\bootstrap\Tabs`
to use
`tag`
configuration option for item container (arturf)
-
Enh #45: Added support for Bootstrap checkbox/radio toggle buttons (RomeroMsk, klimov-paul)
-
Enh #45: Added support for Bootstrap checkbox/radio toggle buttons (RomeroMsk, klimov-paul)
2.
0.5 September 23, 2015
2.
0.5 September 23, 2015
...
...
Tabs.php
View file @
4133d6b2
...
@@ -194,7 +194,8 @@ class Tabs extends Widget
...
@@ -194,7 +194,8 @@ class Tabs extends Widget
}
}
if
(
$this
->
renderTabContent
)
{
if
(
$this
->
renderTabContent
)
{
$panes
[]
=
Html
::
tag
(
'div'
,
isset
(
$item
[
'content'
])
?
$item
[
'content'
]
:
''
,
$options
);
$tag
=
ArrayHelper
::
remove
(
$options
,
'tag'
,
'div'
);
$panes
[]
=
Html
::
tag
(
$tag
,
isset
(
$item
[
'content'
])
?
$item
[
'content'
]
:
''
,
$options
);
}
}
}
}
...
...
tests/TabsTest.php
View file @
4133d6b2
...
@@ -106,4 +106,24 @@ class TabsTest extends TestCase
...
@@ -106,4 +106,24 @@ class TabsTest extends TestCase
$this
->
assertNotContains
(
'InvisibleItem'
,
$html
);
$this
->
assertNotContains
(
'InvisibleItem'
,
$html
);
$this
->
assertNotContains
(
'Invisible Item Content'
,
$html
);
$this
->
assertNotContains
(
'Invisible Item Content'
,
$html
);
}
}
public
function
testItem
()
{
$checkTag
=
'article'
;
$out
=
Tabs
::
widget
([
'items'
=>
[
[
'label'
=>
'Page1'
,
'content'
=>
'Page1'
,
],
[
'label'
=>
'Page2'
,
'content'
=>
'Page2'
,
],
],
'itemOptions'
=>
[
'tag'
=>
$checkTag
],
'renderTabContent'
=>
true
,
]);
$this
->
assertContains
(
'<'
.
$checkTag
,
$out
);
}
}
}
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment