Commit 6dcca6da authored by Oleg Gaidarenko's avatar Oleg Gaidarenko Committed by Dave Methvin

CSS: jQuery#hide should always save display value

Fixes #14750
Closes gh-1509
(cherry picked from commit 5a8f7693)

Conflicts:
	src/css.js
parent 9ec429cf
...@@ -92,13 +92,10 @@ function showHide( elements, show ) { ...@@ -92,13 +92,10 @@ function showHide( elements, show ) {
values[ index ] = jQuery._data( elem, "olddisplay", defaultDisplay(elem.nodeName) ); values[ index ] = jQuery._data( elem, "olddisplay", defaultDisplay(elem.nodeName) );
} }
} else { } else {
hidden = isHidden( elem );
if ( !values[ index ] ) { if ( display && display !== "none" || !hidden ) {
hidden = isHidden( elem ); jQuery._data( elem, "olddisplay", hidden ? display : jQuery.css( elem, "display" ) );
if ( display && display !== "none" || !hidden ) {
jQuery._data( elem, "olddisplay", hidden ? display : jQuery.css( elem, "display" ) );
}
} }
} }
} }
......
...@@ -1106,6 +1106,16 @@ asyncTest( "Make sure initialized display value for disconnected nodes is correc ...@@ -1106,6 +1106,16 @@ asyncTest( "Make sure initialized display value for disconnected nodes is correc
jQuery._removeData( jQuery("#display")[ 0 ] ); jQuery._removeData( jQuery("#display")[ 0 ] );
}); });
test( "show() after hide() should always set display to initial value (#14750)", 1, function() {
var div = jQuery( "<div />" ),
fixture = jQuery( "#qunit-fixture" );
fixture.append( div );
div.css( "display", "inline" ).hide().show().css( "display", "list-item" ).hide().show();
equal( div.css( "display" ), "list-item", "should get last set display value" );
});
// Support: IE < 11, Safari < 7 // Support: IE < 11, Safari < 7
// We have to jump through the hoops here in order to test work with "order" CSS property, // We have to jump through the hoops here in order to test work with "order" CSS property,
// that some browsers do not support. This test is not, strictly speaking, correct, // that some browsers do not support. This test is not, strictly speaking, correct,
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment